jens/brewpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
243 Commits 3 Branches 0 Tags
78ee80f96da9fea8c44270bfc3714e1689e27dc3
Commit Graph
42 Commits
Author SHA1 Message Date
jensandClaude Sonnet 4.6 78ee80f96d Deduplicate TempController/TempController_smith into a shared base 
Both controllers had nearly identical process_fsm(), process_pid(),
and all getters/setters; only Kalman/model setup and process()
genuinely differed, and the duplication had already drifted (the
Smith variant resets model state on entering HEAT, the plain one
didn't).

Add TempControllerBase with the shared logic and three small hooks
(init_kalman, on_state_entered, post_pid) subclasses use to plug in
their own Kalman/model behavior. Each subclass now contains only what
makes it different.

Also fixes a latent crash: TempController's constructor only accepted
(dt, params), but PidFactory/brewpi.py always call it with a third
model_params arg, so pid_type "Normal" would have raised TypeError.
The shared base's model_params=None default fixes this. Also
initializes the Smith controller's trace attributes in __init__
instead of leaving them undefined until the first process() call.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
 2026-06-18 20:50:01 +02:00
jens e8fa90e753 - PID/TC goes Idle state on first theat_ist measurement 2021-10-12 17:13:19 +02:00
jens bf7ec2beaf - PID: introduced INIT State 
- refactored
 2021-10-12 16:47:05 +02:00
jens 425567f3db - refactored 
- increased Hold.Pid.kp
- decrease state change HEAT TO HOLD windows to 1°C
 2021-10-12 09:11:07 +02:00
jens ff90c6d90c - added initial for filling Delay line 
- added gain parameter for Pot sim
- from state change to heat init model temp with plant temp
- updated config template
 2021-10-11 19:54:03 +02:00
jens c5c39732cf - do data signal wiring at one central place 
- fixed initializations
 2021-10-11 13:05:18 +02:00
jens dce3caa1eb - refactored 2021-10-09 12:27:36 +02:00
jens f6394e9e7a - refactored 2021-10-09 10:52:35 +02:00
jens b83ec71346 - refactored 2021-10-09 10:07:45 +02:00
jens 5923212055 - refactored 2021-10-09 09:46:52 +02:00
jens 529ae7ad2f - adjusted params for TC tests 2021-10-02 13:10:10 +02:00
jens 2e143ee03f - implemented APid 
- choose Tempcontroller impl. from config
 2021-10-02 12:24:42 +02:00
jens bf019733b2 - added abstarct PID APid 
- added PidFactory
- use variable args for factory
 2021-10-02 11:10:43 +02:00
jens f2aff73f40 - refactored temp controllers 2020-12-22 10:51:38 +01:00
jens 4c93e85dd8 - improved temp controllers 2020-12-22 10:45:51 +01:00
jens d777a955a4 - refactored dt 2020-12-22 10:26:56 +01:00
jens b5a0e6a7ac - removed dt from params 2020-12-21 16:06:17 +01:00
jens 972e447897 - no kd 2020-12-21 12:43:50 +01:00
jens 5865923854 - refactored params 2020-12-21 12:24:42 +01:00
jens 5f60312d4e - Pid: D-Part need not to be error based 
- increased pot delay to 30 s
 2020-12-20 18:23:14 +01:00
jens 24437329f0 - Compensate for max heat rate to reduce overshoot 2020-12-16 19:54:38 +01:00
jens 71cd87085f - load params from config.json 2020-12-16 18:42:05 +01:00
jens 6dd0920010 - refactored 2020-12-16 17:13:57 +01:00
jens fa93a3911e - refactored 2020-12-16 17:10:46 +01:00
jens 2327b214fc - increased kp 2020-12-13 16:31:20 +01:00
jens 0633e464ca - refactored 
- created TempSensorFactory
 2020-12-13 16:21:08 +01:00
jens 8d57299d83 -added anti windup 2020-12-11 15:17:52 +01:00
jens e5139c5695 - PID-T doesn't need integral term 2020-12-11 14:23:43 +01:00
jens ada81935e3 - temp controller: use series PID for T and dT. PID-T sets setpoint on PIT-dT 2020-12-11 12:43:12 +01:00
jens 52e3cf733d - TC: use offset 2020-12-10 12:46:13 +01:00
jens 424f1d0d0f - fixed initial value for temp_controller 2020-12-10 09:40:38 +01:00
jens a80cc2bf01 - TC: prepared for Rate set and get 
- improved TC state machine
 2020-12-06 12:05:55 +01:00
jens 493af820dc - TC: state IDLE introduced 
- TC: send states
 2020-12-06 11:34:54 +01:00
jens 448afb3e9a - refactored PID params 2020-12-05 18:40:23 +01:00
jens 55aa043efb - tempcontroller: added heat rate control 2020-12-05 18:33:16 +01:00
jens 6939650708 - PID: use pot for testing 2020-12-02 11:24:31 +01:00
jens 5102ad935c - fixed water model 2020-11-29 19:12:17 +01:00
jens d9c587476f - added Temp controller 
- use AttributeChange for Processing objects
 2020-11-29 14:35:44 +01:00
jens 63e4115db8 - improved temp controller test 2020-11-27 12:04:45 +01:00
jens db464080d9 - improved temp controller test 2020-11-26 22:04:22 +01:00
jens bf205742b1 - added Pid 
- added Temp Controller
- added Kalman
 2020-11-26 19:57:28 +01:00
jens 636070fd61 initial import 2020-11-24 18:34:47 +01:00