Files
brewpi/tasks/heater.py
T
jensandClaude Sonnet 4.6 9f221c5d19 fix: re-enable closed-loop on Sud start regardless of client
HeaterTask.shutdown() switched the heater to open-loop when a brew
ended, but nothing switched it back when a new Sud was started.  The
browser happened to send {ClosedLoop: true} as part of its UI setup,
so its connect-and-start path worked; PyQt (and any other client that
doesn't send that message) left the heater in open-loop and the TC
never drove it.

Add SudTask._on_start / set_on_start() hook, HeaterTask.start_closed_loop()
(mirror of shutdown()), and wire them in brewpi.py so the server
switches to closed-loop and broadcasts the new state to all clients the
moment any client starts a brew.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-07-01 00:43:55 +02:00

121 lines
3.7 KiB
Python
Executable File

import asyncio
from tasks import ATask
from components import AHeater
from ws.message import MsgIo
from utils.value import ChangedInteger
class HeaterTask(ATask):
def __init__(self, device: AHeater, interval, msg_handler: MsgIo):
ATask.__init__(self, interval)
self.device = device
self.interval = interval
self.msg_handler = msg_handler
msg_handler.set_recv_handler(self.recv)
self.power_soll = 0
self.power_actor = 0
self.closed_loop = True
self._on_closed_loop_changed = None
self.pulse_counter = 0
device.set_on_changed('power_eff', ChangedInteger(self.on_changed_power).set)
self.power_set_changed = ChangedInteger(self.on_changed_power_set).set
def set_on_closed_loop_changed(self, callback):
self._on_closed_loop_changed = callback
def shutdown(self):
"""Called when the brew ends (DONE/IDLE). Switches to open-loop at
power 0 and disables TC, mirroring what a Stop press should do."""
self.closed_loop = False
self.power_soll = 0
if self._on_closed_loop_changed:
self._on_closed_loop_changed(False)
asyncio.create_task(self.send({'ClosedLoop': False}))
self.power_set_changed(0)
def start_closed_loop(self):
"""Called when a Sud starts. Re-enables closed-loop so the TC drives
the heater regardless of which client started the brew."""
self.closed_loop = True
if self._on_closed_loop_changed:
self._on_closed_loop_changed(True)
asyncio.create_task(self.send({'ClosedLoop': True}))
def actor(self, y):
self.power_actor = max(0, self.device.get_power_max() * y)
def on_changed_power(self, power):
asyncio.create_task(self.send({'Power': power}))
def on_changed_power_set(self, power):
asyncio.create_task(self.send({'PowerSet': power}))
async def recv(self, data):
for pair in data.items():
if pair[0] == 'ClosedLoop':
self.closed_loop = pair[1]
if self.closed_loop:
self.power_soll = 0
if self._on_closed_loop_changed:
self._on_closed_loop_changed(self.closed_loop)
await self.send({'ClosedLoop': self.closed_loop})
elif 'Power' in pair[0]:
self.power_soll = pair[1]
async def send(self, data):
await self.msg_handler.send(data)
def get_next_smaller_power(self, power):
result = self.device.get_power_min()
p_list = [p for p in self.device.get_powers() if p <= power]
if len(p_list) > 0:
result = p_list[-1]
return result
def get_next_greater_power(self, power):
result = self.device.get_power_min()
p_list = [p for p in self.device.get_powers() if p > power]
if len(p_list) > 0:
result = p_list[0]
return result
async def on_process(self):
await self.send({'Capabilities': {'Power': {'Min': 0, 'Max': self.device.get_power_max()}}})
await self.send({'ClosedLoop': self.closed_loop})
if self._on_closed_loop_changed:
self._on_closed_loop_changed(self.closed_loop)
pulse_period_s = 10
pulse_period_count = pulse_period_s/self.interval
with self.device.open():
while True:
# Closed-loop: TC has full control. Open-loop: direct manual power only.
power_soll = self.power_actor if self.closed_loop else self.power_soll
self.power_set_changed(power_soll)
# Calculate duty cycle
power_low = self.get_next_smaller_power(power_soll)
power_high = self.get_next_greater_power(power_soll)
power_step = power_high - power_low
power_diff = power_soll - power_low
duty = power_diff / power_step
on_count = pulse_period_count*duty
self.pulse_counter += 1
if self.pulse_counter >= pulse_period_count:
self.pulse_counter = 0
if power_soll == 0 or self.pulse_counter >= on_count:
self.device.set_power(power_low)
elif self.pulse_counter < on_count:
self.device.set_power(power_high)
self.device.process()
await asyncio.sleep(self.interval)