jensandClaude Sonnet 5
2d032bf9b2
Testing the windup-fix rework live against sude/sud_0030.json surfaced a
distinct bug: a HOLD overshoot from grain-fill-in cooling never decayed -
process_pid()'s pid_outer_y floor clamped to exactly 0.0, so pid_inner
fought the pot's own ambient loss to hold the overshot temperature flat
instead of declining back to setpoint (see docs/overshoot2.png).
Replace the hardcoded 0.0 floor with a configurable Outer.y_hold_min
(default 0.0, backward compatible), set to -0.1 in config.json, both
.tpl templates, and the demo scripts - small enough to avoid
reintroducing the bb5af3c limit cycle while letting HOLD request a
gentle decline matching passive ambient cooling.
Adds TestHoldOvershootRecoversToSetpoint and documents the finding in
docs/overshoot_hold_windup.md's Follow-up section and
components/pid/TODO.md. Confirmed against a live sud_0030 re-run, not
just the unit test.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M2ierBoxW3v7nUbDw3M2pE
120 lines
1.8 KiB
JSON
120 lines
1.8 KiB
JSON
{
|
|
"Name": "Sud-0030",
|
|
"Description": "Münchner Hell",
|
|
"pot": {
|
|
"grain_mass": 0,
|
|
"water_mass": 22,
|
|
"volumen": 30
|
|
},
|
|
"default": {
|
|
"step": {
|
|
"descr": "Put description here",
|
|
"user_message": "Put user message here",
|
|
"user_wait_for_continue": false,
|
|
"pot": {
|
|
"grain_mass": 5.21,
|
|
"water_mass": 22
|
|
},
|
|
"temperature": 0,
|
|
"ramp": {
|
|
"rate": 1.0,
|
|
"stirrer": {
|
|
"speed": 50,
|
|
"interval_time": 0,
|
|
"on_ratio": 1.0
|
|
}
|
|
},
|
|
"hold": {
|
|
"duration": 0,
|
|
"stirrer": {
|
|
"speed": 30,
|
|
"interval_time": 60,
|
|
"on_ratio": 0.5
|
|
}
|
|
}
|
|
}
|
|
},
|
|
"steps": [
|
|
{
|
|
"pot": {
|
|
"grain_mass": 0
|
|
},
|
|
"descr": "Aufheizen",
|
|
"temperature": 57,
|
|
"ramp": {
|
|
"rate": 1.5,
|
|
"stirrer": {
|
|
"speed": 75
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"pot": {
|
|
"grain_mass": 0
|
|
},
|
|
"descr": "Einmaischen",
|
|
"user_message": "Bitte Malz einfüllen und bestätigen",
|
|
"user_wait_for_continue": true,
|
|
"hold": {
|
|
"stirrer": {
|
|
"speed": 0
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"descr": "1. Rast",
|
|
"temperature": 55,
|
|
"hold": {
|
|
"duration": 20
|
|
}
|
|
},
|
|
{
|
|
"descr": "Glucose-Rast",
|
|
"temperature": 63,
|
|
"ramp": {
|
|
"rate": 1.0
|
|
},
|
|
"hold": {
|
|
"duration": 40,
|
|
"stirrer": {
|
|
"speed": 20,
|
|
"interval_time": 90,
|
|
"on_ratio": 0.8
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"descr": "Verzuckerungs-Rast",
|
|
"temperature": 72,
|
|
"ramp": {
|
|
"rate": 1.0
|
|
},
|
|
"hold": {
|
|
"duration": 30,
|
|
"stirrer": {
|
|
"speed": 35,
|
|
"interval_time": 120
|
|
}
|
|
}
|
|
},
|
|
{
|
|
"pot": {
|
|
"water_mass": 20
|
|
},
|
|
"descr": "Abmaischen",
|
|
"user_message": "Quittieren zum Abmaischen",
|
|
"user_wait_for_continue": true,
|
|
"temperature": 76,
|
|
"ramp": {
|
|
"rate": 1.0
|
|
},
|
|
"hold": {
|
|
"duration": 30,
|
|
"stirrer": {
|
|
"speed": 50
|
|
}
|
|
}
|
|
}
|
|
]
|
|
}
|