jens/brewpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove manual tab override/enable checkboxes from browser and PyQt clients

Browse Source 
Drops the tc-enable, heater-activate and stirrer-activate checkboxes
and all associated state, signal connections, initial-sync flags, and
channel-handler logic. Regenerates main_window.py from the updated .ui.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DF16nV2ispNw1C9SbvqbRQ
This commit is contained in:
jens
2026-06-27 20:37:14 +02:00
co-authored by Claude Sonnet 4.6
parent 82acc2d149
commit dd6193fa46
5 changed files with 7 additions and 142 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/app.js
+2 -29
View File
@@ -32,8 +32,6 @@ let initialPowerSync = true;
let initialSpeedSync = true;
let initialHeatrateSync = true;
let initialTempSollSync = true;
let initialHeaterActivateSync = true;
let initialStirrerActivateSync = true;
let ambientTemp = null;
let warpFactor = 1.0;
@@ -524,12 +522,7 @@ function updateSudForecast(doc) {
function onHeaterChanged(msg) {
for (const key of Object.keys(msg)) {
if (key === 'Activate') {
if (initialHeaterActivateSync) {
document.getElementById('heater-activate').checked = !!msg.Activate;
initialHeaterActivateSync = false;
}
} else if (key === 'PowerSet') {
if (key === 'PowerSet') {
heaterPowerSoll = msg.PowerSet;
document.getElementById('lcd-power-soll').textContent = msg.PowerSet;
updateFireVisualization();
@@ -553,12 +546,7 @@ function onHeaterChanged(msg) {
function onStirrerChanged(msg) {
for (const key of Object.keys(msg)) {
if (key === 'Activate') {
if (initialStirrerActivateSync) {
document.getElementById('stirrer-activate').checked = !!msg.Activate;
initialStirrerActivateSync = false;
}
} else if (key === 'Speed') {
if (key === 'Speed') {
stirrerSpeedIst = msg.Speed;
if (initialSpeedSync) {
document.getElementById('stirrer-speed').value = msg.Speed;
@@ -600,12 +588,6 @@ function onTempCtrlChanged(msg) {
initialHeatrateSync = false;
}
}
} else if (key === 'Enabled') {
const enabled = msg.Enabled;
document.getElementById('tc-enabled').checked = enabled;
document.getElementById('temp-soll').disabled = !enabled;
document.getElementById('heatrate-soll').disabled = !enabled;
}
if (key === 'Ist') {
const ist = msg.Ist;
if ('Temp' in ist) {
@@ -791,16 +773,10 @@ document.getElementById('heater-power').addEventListener('input', (e) => {
document.getElementById('heater-power-readout').textContent = e.target.value;
sendMsg('Heater', {Power: Number(e.target.value)});
});
document.getElementById('heater-activate').addEventListener('change', (e) => {
sendMsg('Heater', {Activate: e.target.checked ? 1 : 0});
});
document.getElementById('stirrer-speed').addEventListener('input', (e) => {
document.getElementById('stirrer-speed-readout').textContent = e.target.value;
sendMsg('Stirrer', {Speed: Number(e.target.value)});
});
document.getElementById('stirrer-activate').addEventListener('change', (e) => {
sendMsg('Stirrer', {Activate: e.target.checked ? 1 : 0});
});
document.getElementById('temp-soll').addEventListener('input', (e) => {
document.getElementById('temp-soll-readout').textContent = e.target.value;
sendMsg('TempCtrl', {Soll: {Temp: Number(e.target.value)}});
@@ -808,9 +784,6 @@ document.getElementById('temp-soll').addEventListener('input', (e) => {
document.getElementById('heatrate-soll').addEventListener('change', (e) => {
sendMsg('TempCtrl', {Soll: {Rate: Number(e.target.value)}});
});
document.getElementById('tc-enabled').addEventListener('change', (e) => {
sendMsg('TempCtrl', {Enable: e.target.checked});
});
document.getElementById('ambient-temp').addEventListener('change', (e) => {
sendMsg('System', {AmbientTemp: Number(e.target.value)});
});
web/index.html
+2 -5
View File
@@ -211,18 +211,16 @@
<section id="tab-manual" class="tab-content active">
<div class="panel">
<h3>Controller</h3>
<label><input type="checkbox" id="tc-enabled"> Enabled</label>
<label>Temperature [&deg;C]
<input type="range" id="temp-soll" min="0" max="100" step="1" disabled>
<input type="range" id="temp-soll" min="0" max="100" step="1">
<span id="temp-soll-readout">--</span>
</label>
<label>Heat rate [&deg;C/min]
<input type="number" id="heatrate-soll" min="0" max="3" step="0.1" disabled>
<input type="number" id="heatrate-soll" min="0" max="3" step="0.1">
</label>
</div>
<div class="panel">
<h3>Heater</h3>
<label><input type="checkbox" id="heater-activate"> Activate</label>
<label>Power [W]
<input type="range" id="heater-power" min="0" max="100" step="1">
<span id="heater-power-readout">--</span>
@@ -230,7 +228,6 @@
</div>
<div class="panel">
<h3>Stirrer</h3>
<label><input type="checkbox" id="stirrer-activate"> Activate</label>
<label>Speed [%]
<input type="range" id="stirrer-speed" min="0" max="100" step="1">
<span id="stirrer-speed-readout">--</span>