jens/brewpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash: rename shadowing 'pot' variable in forecast closure

Browse Source 
In estimate()'s on_step_changed closure, the new 'pot = step.get("pot", {})'
local variable shadowed the outer 'pot' (Pot plant instance), causing
pot.set_plant_params() to be called on a plain dict and crash on load.
Renamed to 'step_pot' to avoid the collision.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T52JH848ojhXXHn1bAzdC3
This commit is contained in:
jens
2026-06-26 08:02:53 +02:00
co-authored by Claude Sonnet 4.6
parent e2e3baab08
commit 8c845ed5c5
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/sud_forecast.py
+2 -2
View File
@@ -156,8 +156,8 @@ class SudForecastEstimator:
# re-assigns self.step to retrigger it) - only the *first* call
# for a given index is its actual start.
step_starts.setdefault(sud.index, t[-1])
pot = step.get('pot', {})
params = sud.derive_plant_params(pot.get('grain_mass', 0), pot.get('water_mass', 0))
step_pot = step.get('pot', {})
params = sud.derive_plant_params(step_pot.get('grain_mass', 0), step_pot.get('water_mass', 0))
pot.set_plant_params(params)
tc.set_model_plant_params(params)
if sud.state == SudState.RAMPING and step['temperature'] is not None: