jens/brewpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove PyQt5.Qwt dependency from the GUI client

Browse Source 
PyQt5.Qwt isn't pip-installable; it only existed via the apt package
python3-pyqt5.qwt, so pip-installing client/requirements.txt's plain
PyPI PyQt5 always crashed with "No module named 'PyQt5.Qwt'".

Qwt was only used for 3 QwtSlider widgets (Slider_temp_soll,
Slider_pwr_soll, Slider_speed_soll). Swap them for stock QSlider in
brewpi.ui, regenerate brewpi_win.py via pyuic5, and update
brewpi_gui.py's setLowerBound/setUpperBound calls to QSlider's
integer-only setMinimum/setMaximum. The GUI now runs from a plain
`pip install -r client/requirements.txt` venv with no system PyQt5
packages required.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
jens
2026-06-18 21:24:09 +02:00
co-authored by Claude Sonnet 4.6
parent 1bf3929b60
commit 88357b31f6
4 changed files with 45 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files
README.md
+1 -1
View File
@@ -80,7 +80,7 @@ commands back on (e.g. `{"TempCtrl": {"Soll": {"Temp": 65}}}`).
- Python 3.8+ - Python 3.8+
- Server (`brewpi/requirements.txt`): `numpy`, `scipy`, `websockets`, `dpath`, - Server (`brewpi/requirements.txt`): `numpy`, `scipy`, `websockets`, `dpath`,
and `pyserial`/`spidev` if using real hardware backends. and `pyserial`/`spidev` if using real hardware backends.
- Client (`client/requirements.txt`): `PyQt5` (and `PyQt5.Qwt` for plotting). - Client (`client/requirements.txt`): `PyQt5`.
Install with: Install with:
client/brewpi.ui
+21 -46
View File
@@ -517,7 +517,7 @@
<property name="title"> <property name="title">
<string>Controller</string> <string>Controller</string>
</property> </property>
<widget class="QwtSlider" name="Slider_temp_soll"> <widget class="QSlider" name="Slider_temp_soll">
<property name="geometry"> <property name="geometry">
<rect> <rect>
<x>20</x> <x>20</x>
@@ -526,20 +526,14 @@
<height>281</height> <height>281</height>
</rect> </rect>
</property> </property>
<property name="lowerBound"> <property name="minimum">
<double>0.000000000000000</double> <number>0</number>
</property> </property>
<property name="upperBound"> <property name="maximum">
<double>100.000000000000000</double> <number>100</number>
</property> </property>
<property name="scaleMaxMajor"> <property name="orientation">
<number>7</number> <enum>Qt::Vertical</enum>
</property>
<property name="scaleMaxMinor">
<number>3</number>
</property>
<property name="scaleStepSize">
<double>0.000000000000000</double>
</property> </property>
</widget> </widget>
<widget class="QLabel" name="label_6"> <widget class="QLabel" name="label_6">
@@ -600,7 +594,7 @@
<property name="title"> <property name="title">
<string>Heater</string> <string>Heater</string>
</property> </property>
<widget class="QwtSlider" name="Slider_pwr_soll"> <widget class="QSlider" name="Slider_pwr_soll">
<property name="geometry"> <property name="geometry">
<rect> <rect>
<x>10</x> <x>10</x>
@@ -609,20 +603,14 @@
<height>281</height> <height>281</height>
</rect> </rect>
</property> </property>
<property name="lowerBound"> <property name="minimum">
<double>0.000000000000000</double> <number>0</number>
</property> </property>
<property name="upperBound"> <property name="maximum">
<double>100.000000000000000</double> <number>100</number>
</property> </property>
<property name="scaleMaxMajor"> <property name="orientation">
<number>7</number> <enum>Qt::Vertical</enum>
</property>
<property name="scaleMaxMinor">
<number>3</number>
</property>
<property name="scaleStepSize">
<double>0.000000000000000</double>
</property> </property>
</widget> </widget>
<widget class="QCheckBox" name="checkbox_heater_activate"> <widget class="QCheckBox" name="checkbox_heater_activate">
@@ -674,7 +662,7 @@
<string>Activate</string> <string>Activate</string>
</property> </property>
</widget> </widget>
<widget class="QwtSlider" name="Slider_speed_soll"> <widget class="QSlider" name="Slider_speed_soll">
<property name="geometry"> <property name="geometry">
<rect> <rect>
<x>40</x> <x>40</x>
@@ -683,20 +671,14 @@
<height>281</height> <height>281</height>
</rect> </rect>
</property> </property>
<property name="lowerBound"> <property name="minimum">
<double>0.000000000000000</double> <number>0</number>
</property> </property>
<property name="upperBound"> <property name="maximum">
<double>100.000000000000000</double> <number>100</number>
</property> </property>
<property name="scaleMaxMajor"> <property name="orientation">
<number>7</number> <enum>Qt::Vertical</enum>
</property>
<property name="scaleMaxMinor">
<number>3</number>
</property>
<property name="scaleStepSize">
<double>0.000000000000000</double>
</property> </property>
</widget> </widget>
<widget class="QLabel" name="label_11"> <widget class="QLabel" name="label_11">
@@ -3745,13 +3727,6 @@
</property> </property>
</action> </action>
</widget> </widget>
<customwidgets>
<customwidget>
<class>QwtSlider</class>
<extends>QWidget</extends>
<header>qwt_slider.h</header>
</customwidget>
</customwidgets>
<resources/> <resources/>
<connections/> <connections/>
<designerdata> <designerdata>
client/brewpi_gui.py
+7 -7
View File
@@ -105,7 +105,7 @@ class Window(QtWidgets.QMainWindow, Ui_MainWindow):
if 'Temp' in submsg: if 'Temp' in submsg:
self.lcdNumber_temp_soll.display(str(submsg['Temp'])) self.lcdNumber_temp_soll.display(str(submsg['Temp']))
if self.slider_temp_soll_initial_update: if self.slider_temp_soll_initial_update:
self.Slider_temp_soll.setValue(submsg['Temp']) self.Slider_temp_soll.setValue(int(round(submsg['Temp'])))
self.slider_temp_soll_initial_update = False self.slider_temp_soll_initial_update = False
if 'Rate' in submsg: if 'Rate' in submsg:
subsubmsg = submsg['Rate'] subsubmsg = submsg['Rate']
@@ -133,14 +133,14 @@ class Window(QtWidgets.QMainWindow, Ui_MainWindow):
elif "Power" in key: elif "Power" in key:
self.lcdNumber_power_heater.display(msg['Power']) self.lcdNumber_power_heater.display(msg['Power'])
if self.slider_pwr_initial_update: if self.slider_pwr_initial_update:
self.Slider_pwr_soll.setValue(msg['Power']) self.Slider_pwr_soll.setValue(int(round(msg['Power'])))
self.slider_pwr_initial_update = False self.slider_pwr_initial_update = False
elif "Capabilities" in key: elif "Capabilities" in key:
submsg = msg['Capabilities'] submsg = msg['Capabilities']
if "Power" in submsg: if "Power" in submsg:
submsg = submsg['Power'] submsg = submsg['Power']
self.Slider_pwr_soll.setLowerBound(submsg['Min']) self.Slider_pwr_soll.setMinimum(int(submsg['Min']))
self.Slider_pwr_soll.setUpperBound(submsg['Max']) self.Slider_pwr_soll.setMaximum(int(submsg['Max']))
def on_stirrer_changed(self, msg): def on_stirrer_changed(self, msg):
print("on_stirrer_changed {}".format(msg)) print("on_stirrer_changed {}".format(msg))
@@ -151,14 +151,14 @@ class Window(QtWidgets.QMainWindow, Ui_MainWindow):
self.checkbox_stirrer_activate_initial_update = False self.checkbox_stirrer_activate_initial_update = False
elif "Speed" in key: elif "Speed" in key:
if self.slider_speed_initial_update: if self.slider_speed_initial_update:
self.Slider_speed_soll.setValue(msg['Speed']) self.Slider_speed_soll.setValue(int(round(msg['Speed'])))
self.slider_speed_initial_update = False self.slider_speed_initial_update = False
elif "Capabilities" in key: elif "Capabilities" in key:
submsg = msg['Capabilities'] submsg = msg['Capabilities']
if "Power" in submsg: if "Power" in submsg:
submsg = submsg['Power'] submsg = submsg['Power']
self.Slider_speed_soll.setLowerBound(submsg['Min']) self.Slider_speed_soll.setMinimum(int(submsg['Min']))
self.Slider_speed_soll.setUpperBound(submsg['Max']) self.Slider_speed_soll.setMaximum(int(submsg['Max']))
def closeEvent(self, event): def closeEvent(self, event):
print("Exitting gracefully!") print("Exitting gracefully!")
client/brewpi_win.py
+16 -21
View File
@@ -2,9 +2,10 @@
# Form implementation generated from reading ui file 'brewpi.ui' # Form implementation generated from reading ui file 'brewpi.ui'
# #
# Created by: PyQt5 UI code generator 5.14.1 # Created by: PyQt5 UI code generator 5.15.10
# #
from PyQt5.Qwt import * # WARNING: Any manual changes made to this file will be lost when pyuic5 is
# run again. Do not edit this file unless you know what you are doing.
from PyQt5 import QtCore, QtGui, QtWidgets from PyQt5 import QtCore, QtGui, QtWidgets
@@ -189,13 +190,11 @@ class Ui_MainWindow(object):
self.groupBox_2.setSizePolicy(sizePolicy) self.groupBox_2.setSizePolicy(sizePolicy)
self.groupBox_2.setMinimumSize(QtCore.QSize(0, 0)) self.groupBox_2.setMinimumSize(QtCore.QSize(0, 0))
self.groupBox_2.setObjectName("groupBox_2") self.groupBox_2.setObjectName("groupBox_2")
self.Slider_temp_soll = QwtSlider(self.groupBox_2) self.Slider_temp_soll = QtWidgets.QSlider(self.groupBox_2)
self.Slider_temp_soll.setGeometry(QtCore.QRect(20, 70, 63, 281)) self.Slider_temp_soll.setGeometry(QtCore.QRect(20, 70, 63, 281))
self.Slider_temp_soll.setLowerBound(0.0) self.Slider_temp_soll.setMinimum(0)
self.Slider_temp_soll.setUpperBound(100.0) self.Slider_temp_soll.setMaximum(100)
self.Slider_temp_soll.setScaleMaxMajor(7) self.Slider_temp_soll.setOrientation(QtCore.Qt.Vertical)
self.Slider_temp_soll.setScaleMaxMinor(3)
self.Slider_temp_soll.setScaleStepSize(0.0)
self.Slider_temp_soll.setObjectName("Slider_temp_soll") self.Slider_temp_soll.setObjectName("Slider_temp_soll")
self.label_6 = QtWidgets.QLabel(self.groupBox_2) self.label_6 = QtWidgets.QLabel(self.groupBox_2)
self.label_6.setGeometry(QtCore.QRect(10, 370, 67, 31)) self.label_6.setGeometry(QtCore.QRect(10, 370, 67, 31))
@@ -214,13 +213,11 @@ class Ui_MainWindow(object):
self.horizontalLayout.addWidget(self.groupBox_2) self.horizontalLayout.addWidget(self.groupBox_2)
self.groupBox = QtWidgets.QGroupBox(self.horizontalTabWidgetPage1) self.groupBox = QtWidgets.QGroupBox(self.horizontalTabWidgetPage1)
self.groupBox.setObjectName("groupBox") self.groupBox.setObjectName("groupBox")
self.Slider_pwr_soll = QwtSlider(self.groupBox) self.Slider_pwr_soll = QtWidgets.QSlider(self.groupBox)
self.Slider_pwr_soll.setGeometry(QtCore.QRect(10, 70, 81, 281)) self.Slider_pwr_soll.setGeometry(QtCore.QRect(10, 70, 81, 281))
self.Slider_pwr_soll.setLowerBound(0.0) self.Slider_pwr_soll.setMinimum(0)
self.Slider_pwr_soll.setUpperBound(100.0) self.Slider_pwr_soll.setMaximum(100)
self.Slider_pwr_soll.setScaleMaxMajor(7) self.Slider_pwr_soll.setOrientation(QtCore.Qt.Vertical)
self.Slider_pwr_soll.setScaleMaxMinor(3)
self.Slider_pwr_soll.setScaleStepSize(0.0)
self.Slider_pwr_soll.setObjectName("Slider_pwr_soll") self.Slider_pwr_soll.setObjectName("Slider_pwr_soll")
self.checkbox_heater_activate = QtWidgets.QCheckBox(self.groupBox) self.checkbox_heater_activate = QtWidgets.QCheckBox(self.groupBox)
self.checkbox_heater_activate.setGeometry(QtCore.QRect(30, 370, 81, 31)) self.checkbox_heater_activate.setGeometry(QtCore.QRect(30, 370, 81, 31))
@@ -235,13 +232,11 @@ class Ui_MainWindow(object):
self.checkbox_stirrer_activate = QtWidgets.QCheckBox(self.groupBox_3) self.checkbox_stirrer_activate = QtWidgets.QCheckBox(self.groupBox_3)
self.checkbox_stirrer_activate.setGeometry(QtCore.QRect(40, 370, 81, 23)) self.checkbox_stirrer_activate.setGeometry(QtCore.QRect(40, 370, 81, 23))
self.checkbox_stirrer_activate.setObjectName("checkbox_stirrer_activate") self.checkbox_stirrer_activate.setObjectName("checkbox_stirrer_activate")
self.Slider_speed_soll = QwtSlider(self.groupBox_3) self.Slider_speed_soll = QtWidgets.QSlider(self.groupBox_3)
self.Slider_speed_soll.setGeometry(QtCore.QRect(40, 70, 63, 281)) self.Slider_speed_soll.setGeometry(QtCore.QRect(40, 70, 63, 281))
self.Slider_speed_soll.setLowerBound(0.0) self.Slider_speed_soll.setMinimum(0)
self.Slider_speed_soll.setUpperBound(100.0) self.Slider_speed_soll.setMaximum(100)
self.Slider_speed_soll.setScaleMaxMajor(7) self.Slider_speed_soll.setOrientation(QtCore.Qt.Vertical)
self.Slider_speed_soll.setScaleMaxMinor(3)
self.Slider_speed_soll.setScaleStepSize(0.0)
self.Slider_speed_soll.setObjectName("Slider_speed_soll") self.Slider_speed_soll.setObjectName("Slider_speed_soll")
self.label_11 = QtWidgets.QLabel(self.groupBox_3) self.label_11 = QtWidgets.QLabel(self.groupBox_3)
self.label_11.setGeometry(QtCore.QRect(0, 30, 141, 31)) self.label_11.setGeometry(QtCore.QRect(0, 30, 141, 31))
@@ -1277,7 +1272,7 @@ class Ui_MainWindow(object):
self.label_5.setText(_translate("MainWindow", "Power [W]")) self.label_5.setText(_translate("MainWindow", "Power [W]"))
self.label_7.setText(_translate("MainWindow", "State")) self.label_7.setText(_translate("MainWindow", "State"))
self.label_state.setText(_translate("MainWindow", "State")) self.label_state.setText(_translate("MainWindow", "State"))
self.plainTextUri.setPlainText(_translate("MainWindow", "ws://localhost:8765")) self.plainTextUri.setPlainText(_translate("MainWindow", "ws://brewpi:8765"))
self.label_8.setText(_translate("MainWindow", "Host")) self.label_8.setText(_translate("MainWindow", "Host"))
self.menu_File.setTitle(_translate("MainWindow", "&File")) self.menu_File.setTitle(_translate("MainWindow", "&File"))
self.menu_Help.setTitle(_translate("MainWindow", "&Help")) self.menu_Help.setTitle(_translate("MainWindow", "&Help"))