Add set_ambient_temperature and set_model_plant_params stubs to TempControllerBase
Same pattern as set_model_power: these methods only existed on the Smith controller, forcing five hasattr guards at call sites. No-op stubs on the base class give all controllers a stable interface; Smith overrides them. Remove the now-redundant hasattr guards. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Tqxrk8uj4M3w3d3eXm3xK8
This commit is contained in:
+2
-4
@@ -118,8 +118,7 @@ if __name__ == '__main__':
|
||||
# ever coming from a Sud's own doc.
|
||||
tc = PidFactory.create(config['Controller']['pid_type'], DT)
|
||||
tc.set_params(config['TempCtrl'])
|
||||
if hasattr(tc, 'set_ambient_temperature'):
|
||||
tc.set_ambient_temperature(theta_amb)
|
||||
tc.set_ambient_temperature(theta_amb)
|
||||
tc_task = TcTask(tc, DT_TASK, dispatcher.msgio_get("TempCtrl"))
|
||||
taskmgr.add(tc_task)
|
||||
|
||||
@@ -171,8 +170,7 @@ if __name__ == '__main__':
|
||||
if 'AmbientTemp' in data:
|
||||
theta_amb = data['AmbientTemp']
|
||||
pot.set_ambient_temperature(theta_amb)
|
||||
if hasattr(tc, 'set_ambient_temperature'):
|
||||
tc.set_ambient_temperature(theta_amb)
|
||||
tc.set_ambient_temperature(theta_amb)
|
||||
forecast_estimator.set_ambient_temperature(theta_amb)
|
||||
await msg_system.send({'AmbientTemp': theta_amb})
|
||||
msg_system.set_recv_handler(on_system_recv)
|
||||
|
||||
Reference in New Issue
Block a user