jens/brewpi
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: guard HeaterHendi/StirrerPololu1376 activate() against comm errors

Browse Source 
Live-testing on the brewpi Pi found that a connected-but-unresponsive
device (e.g. the hendi sitting in its ungraceful-disconnect lockout, see
docs/hendi_lockout_findings.md) crashed the whole server: activate() -
called both from HeaterTask's `with device.open():` and from a client's
Connect/Disconnect command - raised uncaught, escaping the gathered task
and killing the entire asyncio.gather in TaskManager.start().

activate()/is_activated()/process() on both real actors now catch comm
exceptions and self-heal via disconnect() (the same path a genuine
unplug already takes), instead of letting the exception propagate.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YaPLuRPpyjWcwhMvCvpHCL
This commit is contained in:
jens
2026-07-03 19:39:07 +02:00
co-authored by Claude Sonnet 5
parent 1db0e66ab7
commit 0877e7754b
2 changed files with 65 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
components/actor/heater_hendi.py
+34 -13
View File
@@ -34,28 +34,49 @@ class HeaterHendi(AHeater):
def activate(self, enable):
if not self.connected:
return
if enable:
self.hendi.remoteEnable(1)
else:
self.hendi.setSwitch(0)
try:
if enable:
self.hendi.remoteEnable(1)
else:
self.hendi.setSwitch(0)
except Exception as e:
# A device that was connected can still fail a live command (the
# hendi's own idle-timeout auto-suspend, a cable pulled mid-run,
# ...) - treat that the same as a disconnect rather than letting
# it escape uncaught, since this is called both from HeaterTask's
# tick loop (with self.device.open(): activate(True)/(False)) and
# from a client's Connect/Disconnect command, neither of which
# expect activate() itself to ever raise.
print(f"HeaterHendi: comm error in activate({enable}): {e}")
self.disconnect()
def is_activated(self):
if not self.connected:
return False
s = self.hendi.isRemoteEnable()
return '1' in s
try:
s = self.hendi.isRemoteEnable()
return '1' in s
except Exception as e:
print(f"HeaterHendi: comm error in is_activated: {e}")
self.disconnect()
return False
def process(self):
if not self.connected:
self.power_eff = 0
return
power = self.power_set
if power == 0:
self.hendi.setSwitch(0)
else:
self.hendi.setSwitch(1)
self.hendi.setPowerWatts(power)
self.power_eff = self.hendi.getPowerWatts() if power > 0 else 0
try:
power = self.power_set
if power == 0:
self.hendi.setSwitch(0)
else:
self.hendi.setSwitch(1)
self.hendi.setPowerWatts(power)
self.power_eff = self.hendi.getPowerWatts() if power > 0 else 0
except Exception as e:
print(f"HeaterHendi: comm error in process: {e}")
self.disconnect()
self.power_eff = 0
def set_power(self, power):
self.power_set = min(self.get_power_max(), power)